Re: [PATCH 04/11] iov_iter: explicitly check for CHECK_IOVEC_ONLY in rw_copy_check_uvector
From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2020-09-21 15:07:59
Also in:
io-uring, keyrings, linux-arch, linux-arm-kernel, linux-block, linux-fsdevel, linux-mips, linux-mm, linux-s390, linux-scsi, linux-security-module, linuxppc-dev, lkml, sparclinux
On Mon, Sep 21, 2020 at 04:34:27PM +0200, Christoph Hellwig wrote:
Explicitly check for the magic value insted of implicitly relying on its numeric representation. Also drop the rather pointless unlikely annotation.
See above - I would rather have CHECK_IOVEC_ONLY gone. The reason for doing these access_ok() in the same loop is fairly weak, especially since you are checking type on each iteration. Might as well do that in a separate loop afterwards.