Thread (4 messages) 4 messages, 3 authors, 2020-09-15

Re: [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON_ONCE() when trying to check id

From: Matthew Wilcox <willy@infradead.org>
Date: 2020-09-14 19:27:20
Also in: linux-fsdevel, linux-kernel-mentees, lkml

On Tue, Sep 15, 2020 at 12:17:55AM +0530, Anmol Karn wrote:
On Mon, Sep 14, 2020 at 12:08:03PM +0100, Matthew Wilcox wrote:
quoted
On Mon, Sep 14, 2020 at 12:47:24PM +0530, Anmol Karn wrote:
quoted
idr_get_next() gives WARN_ON_ONCE() when it gets (id > INT_MAX) true
and this happens when syzbot does fuzzing, and that warning is
expected, but WARN_ON_ONCE() is not required here and, cecking
the condition and returning NULL value would be suffice.

Reference: commit b9959c7a347 ("filldir[64]: remove WARN_ON_ONCE() for bad directory entries")
Reported-and-tested-by: syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=f7204dcf3df4bb4ce42c 
Signed-off-by: Anmol Karn <redacted>
https://lore.kernel.org/netdev/20200605120037.17427-1-willy@infradead.org/ (local)
Hello sir,

I have looked into the patch, and it seems the problem is fixed to the root cause
in this patch, but not yet merged due to some backport issues, so, please ignore 
this patch(sent by me), and please let me know if i can contribute to fixing this 
bug's root cause.
The root cause is that the network maintainers believe I have a far
greater interest in the qrtr code than I actually do, and the maintainer
of the qrtr code is not doing anything.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help