On Tue, 29 Sep 2020 19:04:13 +0200 Andrew Lunn wrote:

On Tue, Sep 29, 2020 at 07:13:04PM +0300, Igor Russkikh wrote:

quoted

This series implements phy tunables settings via MAC driver callbacks.

AQC 10G devices use integrated MAC+PHY solution, where PHY is fully controlled
by MAC firmware. Therefore, it is not possible to implement separate phy driver
for these.

We use ethtool ops callbacks to implement downshift and EDPC tunables.  

Hi Michal

Do you have any code to implement tunables via netlink?

This code is defining new ethtool calls. It seems like now would be a
good time to plumb in extack, so the driver can report back the valid
range of a tunable when given an unsupported value.

Do you mean report supported range via extack? Perhaps we should have 
a real API for that kind of info? We can plumb it through to the core
for now and expose to user space once netlink comes.