Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel

On Thu, Sep 24, 2020 at 3:01 AM David Miller [off-list ref] wrote:

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Tue, 22 Sep 2020 23:41:12 +0200

quoted

The TX DMA channel data is accessed by the xrx200_start_xmit() and the
xrx200_tx_housekeeping() function from different threads. Make sure the
accesses are synchronized by acquiring the netif_tx_lock() in the
xrx200_tx_housekeeping() function too. This lock is acquired by the
kernel before calling xrx200_start_xmit().

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Applied, but...

You posted this really fast after my feedback, so I have to ask if you
actually functionally tested this patch?

it fixes the following crash for me: [0]


Best regards,
Martin


[0] https://pastebin.com/t1SLz9PH