Thread (5 messages) 5 messages, 3 authors, 2020-09-20

Re: [PATCH v2] net: sctp: Fix IPv6 ancestor_size calc in sctp_copy_descendant

From: David Miller <davem@davemloft.net>
Date: 2020-09-20 21:16:32
Also in: linux-sctp

From: Henry Ptasinski <redacted>
Date: Sat, 19 Sep 2020 00:12:11 +0000
When calculating ancestor_size with IPv6 enabled, simply using
sizeof(struct ipv6_pinfo) doesn't account for extra bytes needed for
alignment in the struct sctp6_sock. On x86, there aren't any extra
bytes, but on ARM the ipv6_pinfo structure is aligned on an 8-byte
boundary so there were 4 pad bytes that were omitted from the
ancestor_size calculation.  This would lead to corruption of the
pd_lobby pointers, causing an oops when trying to free the sctp
structure on socket close.

Fixes: 636d25d557d1 ("sctp: not copy sctp_sock pd_lobby in sctp_copy_descendant")
Signed-off-by: Henry Ptasinski <redacted>
Applied and queued up for -stable, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help