Thread (3 messages) 3 messages, 3 authors, 2020-09-04

RE: [Intel-wired-lan] [PATCH][v2] i40e: optimise prefetch page refcount

From: Brown, Aaron F <hidden>
Date: 2020-09-04 23:30:43
Also in: intel-wired-lan

From: Intel-wired-lan <redacted> On Behalf Of Li
RongQing
Sent: Friday, July 31, 2020 3:38 AM
To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
kuba@kernel.org; Bowers, AndrewX [off-list ref];
Nguyen, Anthony L [off-list ref]
Subject: [Intel-wired-lan] [PATCH][v2] i40e: optimise prefetch page refcount

refcount of rx_buffer page will be added here originally, so prefetchw
is needed, but after commit 1793668c3b8c ("i40e/i40evf: Update code to
 better handle incrementing page count"), and refcount is not added
everytime, so change prefetchw as prefetch,

now it mainly services page_address(), but which accesses struct page
only when WANT_PAGE_VIRTUAL or HASHED_PAGE_VIRTUAL is defined
otherwise
it returns address based on offset, so we prefetch it conditionally

Jakub suggested to define prefetch_page_address in a common header

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Li RongQing <redacted>
---
diff with v1: create a common function prefetch_page_address

 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
 include/linux/prefetch.h                    | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)
Tested-by: Aaron Brown <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help