Re: [PATCH ethtool] ethtool: add support show/set-hwtstamp

On Wed, Sep 2, 2020 at 2:36 AM Kevin Yang [off-list ref] wrote:

Hi Andrew,

They are pretty much the same, both use ioctl(SIOCSHWTSTAMP).

Adding this to ethtool is because:
- This time stamping policy is a hardware setting aligned with ethtool's purpose "query and control network device driver and hardware settings"
- ethtool is widely used, system administrators don't need to install another binary to control this feature.

Absolutely. ethtool has -T support already, and is the facto tool for
things not covered by iproute2 suite.

Having to remember a myriad of binaries that basically use a single
ioctl() is time consuming.

Kevin

On Tue, Sep 1, 2020 at 6:02 PM Andrew Lunn [off-list ref] wrote:

quoted

On Tue, Sep 01, 2020 at 05:20:09PM -0400, Kevin(Yudong) Yang wrote:

quoted

Before this patch, ethtool has -T/--show-time-stamping that only
shows the device's time stamping capabilities but not the time
stamping policy that is used by the device.

Hi Kavin

How does this differ from hwstamp_ctl(1)?

    Andrew