Re: [PATCH 5/5] net: phy: smsc: LAN8710/LAN8720: remove PHY_RST_AFTER_CLK_EN flag
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-08-31 14:11:27
Also in:
linux-devicetree
On Mon, Aug 31, 2020 at 03:48:36PM +0200, Marco Felsch wrote:
quoted hunk ↗ jump to hunk
Don't reset the phy without respect to the phy-state-machine because this breaks the phy IRQ mode. We can archive the same behaviour if the refclk in is specified. Signed-off-by: Marco Felsch <redacted> --- drivers/net/phy/smsc.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index b98a7845681f..67adf11ef958 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c@@ -337,7 +337,6 @@ static struct phy_driver smsc_phy_driver[] = { .name = "SMSC LAN8710/LAN8720", /* PHY_BASIC_FEATURES */ - .flags = PHY_RST_AFTER_CLK_EN, .probe = smsc_phy_probe,
Hi Marco There are two PHYs using PHY_RST_AFTER_CLK_EN. What about the other one? Andrew