Re: [PATCH bpf-next 1/5] bpf: make bpf_link_info.iter similar to bpf_iter_link_info

On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song [off-list ref] wrote:

bpf_link_info.iter is used by link_query to return
bpf_iter_link_info to user space. Fields may be different
,e.g., map_fd vs. map_id, so we cannot reuse
the exact structure. But make them similar, e.g.,
  struct bpf_link_info {
     /* common fields */
     union {
        struct { ... } raw_tracepoint;
        struct { ... } tracing;
        ...
        struct {
            /* common fields for iter */
            union {
                struct {
                    __u32 map_id;
                } map;
                /* other structs for other targets */
            };
        };
    };
 };
so the structure is extensible the same way as
bpf_iter_link_info.

Fixes: 6b0a249a301e ("bpf: Implement link_query for bpf iterators")
Signed-off-by: Yonghong Song <redacted>
---

I like this change, thanks!

Acked-by: Andrii Nakryiko <redacted>

 include/uapi/linux/bpf.h       | 6 ++++--
 tools/include/uapi/linux/bpf.h | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

[...]