Thread (3 messages) flat view 3 messages, 3 authors, 2020-08-13

Re: [PATCH bpf] tools/bpftool: make skeleton code C++17-friendly by dropping typeof()

From: Alexei Starovoitov <hidden>
Date: 2020-08-13 01:11:08
Also in: bpf

On Wed, Aug 12, 2020 at 8:35 AM Song Liu [off-list ref] wrote:

quoted
On Aug 11, 2020, at 7:59 PM, Andrii Nakryiko [off-list ref] wrote:

Seems like C++17 standard mode doesn't recognize typeof() anymore. This can
be tested by compiling test_cpp test with -std=c++17 or -std=c++1z options.
The use of typeof in skeleton generated code is unnecessary, all types are
well-known at the time of code generation, so remove all typeof()'s to make
skeleton code more future-proof when interacting with C++ compilers.

Fixes: 985ead416df3 ("bpftool: Add skeleton codegen command")
Signed-off-by: Andrii Nakryiko <redacted>
Acked-by: Song Liu <redacted>
Applied. Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help