Thread (5 messages) 5 messages, 4 authors, 2020-09-01

Re: sysfs output without newlines

From: Denis Efremov <efremov@linux.com>
Date: 2020-08-29 20:24:01
Also in: linux-arm-kernel, linux-edac, linux-i3c, linux-mmc, linux-scsi, linux-spi, linux-usb, linux-wireless, lkml, platform-driver-x86

Hi,

On 8/29/20 9:23 PM, Joe Perches wrote:
While doing an investigation for a possible treewide conversion of
sysfs output using sprintf/snprintf/scnprintf, I discovered
several instances of sysfs output without terminating newlines.

It seems likely all of these should have newline terminations
or have the \n\r termination changed to a single newline.
I think that it could break badly written scripts in rare cases.
Anyone have any objection to patches adding newlines to these
in their original forms using sprintf/snprintf/scnprintf?
I'm not sure about existing cases, but I think it's a good
checkpatch.pl warning for new patches. It should be 
possible to check sysfs_emit() calls.

Thanks,
Denis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help