Re: [PATCH][next] ath11k: fix error check on return from call to ath11k_core_firmware_request
From: Kalle Valo <hidden>
Date: 2020-08-27 11:43:16
Also in:
kernel-janitors, linux-wireless, lkml
From: Kalle Valo <hidden>
Date: 2020-08-27 11:43:16
Also in:
kernel-janitors, linux-wireless, lkml
Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>
The call to ath11k_core_firmware_request is returning a pointer that
can be set to an error code, however, this is not being checked.
Instead ret is being incorrecly checked for the error return. Fix the
error checking.
Addresses-Coverity: ("Logically dead code")
Fixes: 7b57b2ddec21 ("ath11k: create a common function to request all firmware files")
Signed-off-by: Colin Ian King <redacted>A similar patch has been already applied. error: patch failed: drivers/net/wireless/ath/ath11k/qmi.c:1886 error: drivers/net/wireless/ath/ath11k/qmi.c: patch does not apply stg import: Diff does not apply cleanly Patch set to Rejected. -- https://patchwork.kernel.org/patch/11723519/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches