Thread (2 messages) flat view 2 messages, 2 authors, 2020-08-25

Re: [PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

From: David Miller <davem@davemloft.net>
Date: 2020-08-25 14:48:50
Also in: linux-arm-kernel, linux-mediatek, lkml

From: Sumera Priyadarsini <redacted>
Date: Tue, 25 Aug 2020 01:33:11 +0530
Every iteration of for_each_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in mt7530.c by inserting of_node_put()
before the break and return statements.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help