Thread (3 messages) 3 messages, 3 authors, 2020-08-25

Re: [PATCH] typhoon: switch from 'pci_' to 'dma_' API

From: David Miller <davem@davemloft.net>
Date: 2020-08-25 00:33:42
Also in: kernel-janitors, lkml

From: Christophe JAILLET <redacted>
Date: Sun, 23 Aug 2020 08:11:50 +0200
The wrappers in include/linux/pci-dma-compat.h should go away.

The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.

When memory is allocated in 'typhoon_init_one()' GFP_KERNEL can be used
because it is a probe function and no lock is acquired.

When memory is allocated in 'typhoon_download_firmware()', GFP_ATOMIC
must be used because it can be called from a .ndo_tx_timeout function.
So this function can be called with the 'netif_tx_lock' acquired.
The call chain is:
  --> typhoon_tx_timeout                 (.ndo_tx_timeout function)
    --> typhoon_start_runtime
      --> typhoon_download_firmware

While at is, update some comments accordingly.
 ...
Signed-off-by: Christophe JAILLET <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help