Thread (34 messages) 34 messages, 5 authors, 2020-09-22

Re: [PATCH v3 05/11] genirq: Shutdown irq chips in suspend/resume during hibernation

From: Thomas Gleixner <hidden>
Date: 2020-08-22 00:36:42
Also in: linux-mm, linux-pm, lkml, xen-devel

On Fri, Aug 21 2020 at 22:27, Thomas Gleixner wrote:
Add a new quirk flag IRQCHIP_SHUTDOWN_ON_SUSPEND and add support for
it the core interrupt suspend/resume paths.

Changelog:
v1->v2: Corrected the author's name to tglx@
Can you please move that Changelog part below the --- seperator next
time because that's really not part of the final commit messaage and the
maintainer has then to strip it off manually
 
Signed-off-by: Anchal Agarwal <redacted>
Signed-off-by: Thomas Gleixner <redacted>
These SOB lines are just wrongly ordered as they suggest:

     Anchal has authored the patch and Thomas transported it

which is clearly not the case. So the right order is:

Signed-off-by: Thomas Gleixner <redacted>
Signed-off-by: Anchal Agarwal <redacted>

And that needs another tweak at the top of the change log. The first
line in the mail body wants to be:

From: Thomas Gleixner <redacted>

followed by an empty new line before the actual changelog text
starts. That way the attribution of the patch when applying it will be
correct.

Documentation/process/ is there for a reason and following the few
simple rules to get that straight is not rocket science.

Thanks,

        tglx

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help