Thread (3 messages) flat view 3 messages, 3 authors, 2020-08-21

Re: [PATCH] net: dsa: b53: check for timeout

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2020-08-21 14:43:27
Also in: lkml


On 8/21/2020 6:56 AM, trix@redhat.com wrote:
From: Tom Rix <trix@redhat.com>

clang static analysis reports this problem

b53_common.c:1583:13: warning: The left expression of the compound
   assignment is an uninitialized value. The computed value will
   also be garbage
         ent.port &= ~BIT(port);
         ~~~~~~~~ ^

ent is set by a successful call to b53_arl_read().  Unsuccessful
calls are caught by an switch statement handling specific returns.
b32_arl_read() calls b53_arl_op_wait() which fails with the
unhandled -ETIMEDOUT.

So add -ETIMEDOUT to the switch statement.  Because
b53_arl_op_wait() already prints out a message, do not add another
one.

Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
For future submissions: no need for a newline between your tags here, 
the Fixes tag is just a regular tag in the commit message.
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help