Re: [PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h

From
Coly Li <hidden>
Date
2020-08-19 04:22:21
Also in
ceph-devel, linux-block, linux-nvme, linux-scsi, lkml, stable
Reply to
Christoph Hellwig, 2020-08-18
On 2020/8/19 03:49, Christoph Hellwig wrote:
On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote:
quoted
On 2020/8/19 00:24, Christoph Hellwig wrote:
quoted
I think we should go for something simple like this instead:
This idea is fine to me. Should a warning message be through here? IMHO
the driver still sends an improper page in, fix it in silence is too
kind or over nice to the buggy driver(s).
I don't think a warning is a good idea.  An API that does the right
thing underneath and doesn't require boiler plate code in most callers
is the right API.
Then I don't have more comment.

Thanks.

Coly Li
Thread (13 messages) 13 messages, 2 authors, last reply 2020-09-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help