Thread (2 messages) flat view 2 messages, 2 authors, 2020-08-18

Re: [PATCH] net: gianfar: Add of_node_put() before goto statement

From: David Miller <davem@davemloft.net>
Date: 2020-08-18 20:13:49
Also in: lkml

From: Sumera Priyadarsini <redacted>
Date: Wed, 19 Aug 2020 00:22:41 +0530
Every iteration of for_each_available_child_of_node() decrements
reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in gianfar.c by inserting of_node_put()
before the goto statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <redacted>
These OF iterators are so error prone...

Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help