Re: [PATCH] rpl_iptunnel: simplify the return expression of rpl_do_srh()
From: David Miller <davem@davemloft.net>
Date: 2020-08-18 19:35:54
Also in:
lkml
From: Xu Wang <redacted> Date: Tue, 18 Aug 2020 08:54:54 +0000
quoted hunk ↗ jump to hunk
@@ -197,11 +197,7 @@ static int rpl_do_srh(struct sk_buff *skb, const struct rpl_lwt *rlwt) tinfo = rpl_encap_lwtunnel(dst->lwtstate); - err = rpl_do_srh_inline(skb, rlwt, tinfo->srh); - if (err) - return err; - - return 0; + return rpl_do_srh_inline(skb, rlwt, tinfo->srh); }
Please at least compile test your changes: net/ipv6/rpl_iptunnel.c: In function ‘rpl_do_srh’: net/ipv6/rpl_iptunnel.c:193:6: warning: unused variable ‘err’ [-Wunused-variable] 193 | int err = 0;