Re: [PATCH] ath10k: fix the status check and wrong return

Tang Bin [off-list ref] writes:

在 2020/8/17 22:26, Kalle Valo 写道:

quoted

quoted

In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't
return NULL. Thus use IS_ERR() and PTR_ERR() to validate
the returned value instead of IS_ERR_OR_NULL().

Why? What's the benefit of this patch? Or what harm does
IS_ERR_OR_NULL() create?

Thanks for you reply, the benefit of this patch is simplify the code,
because in

this function, I don't think the situation of 'devm_clk_get() return
NULL' exists.

So please think about it, thanks.

I think you missed my comment below:

quoted

devm_clk_get() can return NULL if CONFIG_HAVE_CLK is disabled:

static inline struct clk *devm_clk_get(struct device *dev, const char *id)
{
	return NULL;
}

So I think this patch just creates a new bug and does not improve
anything.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches