RE: [PATCH] kprobes: fix compiler warning for !CONFIG_KPROBES_ON_FTRACE

From
John Fastabend <john.fastabend@gmail.com>
Date
2020-08-06 11:01:26
Also in
bpf, lkml
Reply to
Muchun Song, 2020-08-05
Muchun Song wrote:
Fix compiler warning(as show below) for !CONFIG_KPROBES_ON_FTRACE.

kernel/kprobes.c: In function 'kill_kprobe':
kernel/kprobes.c:1116:33: warning: statement with no effect
[-Wunused-value]
 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
      |                                 ^
kernel/kprobes.c:2154:3: note: in expansion of macro
'disarm_kprobe_ftrace'
 2154 |   disarm_kprobe_ftrace(p);

Link: https://lore.kernel.org/r/20200805142136.0331f7ea@canb.auug.org.au (local)

Reported-by: Stephen Rothwell <redacted>
Fixes: 0cb2f1372baa ("kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler")
Signed-off-by: Muchun Song <redacted>
---
Acked-by: John Fastabend <john.fastabend@gmail.com>
Thread (3 messages) 3 messages, 3 authors, last reply 2020-08-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help