Re: [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key()
From: Peilin Ye <hidden>
Date: 2020-08-03 22:39:48
Also in:
linux-kernel-mentees, lkml
From: Peilin Ye <hidden>
Date: 2020-08-03 22:39:48
Also in:
linux-kernel-mentees, lkml
On Mon, Aug 03, 2020 at 03:10:38PM -0700, David Miller wrote:
From: Peilin Ye <redacted> Date: Fri, 31 Jul 2020 00:48:38 -0400quoted
ovs_ct_put_key() is potentially copying uninitialized kernel stack memory into socket buffers, since the compiler may leave a 3-byte hole at the end of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix it by initializing `orig` with memset(). Cc: stable@vger.kernel.orgPlease don't CC: stable for networking fixes.
Sorry, I didn't know about that.
quoted
Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to sw_flow_key.") Suggested-by: Dan Carpenter <redacted> Signed-off-by: Peilin Ye <redacted>Applied and queued up for -stable, thank you.
Thank you for reviewing the patch! Peilin Ye