On Thu, 20 Aug 2020 21:51:58 +0300 Igor Russkikh wrote:

Here we return existing fw & mfw versions, we also fetch device's
serial number:

~$ sudo ~/iproute2/devlink/devlink  dev info
pci/0000:01:00.1:
  driver qed
  board.serial_number REE1915E44552
  versions:
      running:
        fw.app 8.42.2.0
      stored:
        fw.mgmt 8.52.10.0

Are you not able to report the running version of the stored firmware?
The two sections are used for checking if machine needs fw-activation
or reboot (i.e. if fw.mgmt in stored section does not match fw.mgmt in
running - there is a new FW to activate).

MFW and FW are different firmwares on device.
Management is a firmware responsible for link configuration and
various control plane features. Its permanent and resides in NVM.

Running FW (or fastpath FW) is an embedded microprogram implementing
all the packet processing, offloads, etc. This FW is being loaded
on each start by the driver from FW binary blob.

The base device specific structure (qed_dev_info) was not directly
available to the base driver before. Thus, here we create and store
a private copy of this structure in qed_dev root object to
access the data.

In general looks good:

Reviewed-by: Jakub Kicinski <kuba@kernel.org>