Re: [PATCH ethtool 2/7] ioctl: check presence of eeprom length argument properly
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-08-10 14:12:25
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-08-10 14:12:25
On Sun, Aug 09, 2020 at 11:24:22PM +0200, Michal Kubecek wrote:
In do_geeprom(), do_seprom() and do_getmodule(), check if user used "length" command line argument is done by setting the value to -1 before parsing and checking if it changed. This is quite ugly and also causes compiler warnings as the variable is u32. Use proper "seen" flag to let parser tell us if the argument was used. Signed-off-by: Michal Kubecek <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew