Re: [PATCH ethtool 0/7] compiler warnings cleanup, part 1

On Mon, Aug 03, 2020 at 03:31:25PM +0200, Andrew Lunn wrote:

On Mon, Aug 03, 2020 at 01:57:03PM +0200, Michal Kubecek wrote:

quoted

Maciej Żenczykowski recently cleaned up many "unused parameter" compiler
warnings but some new occurences appeared since (mostly in netlink code).

Hi Michal

Could you modify the compiler flags to get gcc to warn about these?
Otherwise they will just come back again.

Good point. I'll add "-Wextra" to default CFLAGS in Makefile.am with the
second part of the cleanup (shortly after 5.8 release). At that point
there will be no warnings so that it will be easy to spot any new ones.

Michal