Re: [PATCH v8 bpf-next 01/13] selftests/bpf: Fix resolve_btfids test

On Wed, Jul 29, 2020 at 1:07 PM Jiri Olsa [off-list ref] wrote:

On Tue, Jul 28, 2020 at 01:27:49PM -0700, Andrii Nakryiko wrote:

quoted

On Wed, Jul 22, 2020 at 2:13 PM Jiri Olsa [off-list ref] wrote:

quoted

The linux/btf_ids.h header is now using CONFIG_DEBUG_INFO_BTF
config, so we need to have it defined when it's available.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---

sure, why not

actually after rebase I realized Yonghong added
CONFIG_DEBUG_INFO_BTF define in:
  d8dfe5bfe856 ("tools/bpf: Sync btf_ids.h to tools")

I think including 'autoconf.h' is more clean,
on the other hand I don't think we'd get clean
selftest compile without CONFIG_DEBUG_INFO_BTF

should we keep the #define instead?

#define is fine with me

thanks,
jirka

quoted

Acked-by: Andrii Nakryiko <redacted>

quoted

 tools/testing/selftests/bpf/prog_tests/resolve_btfids.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c b/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c
index 3b127cab4864..101785b49f7e 100644
--- a/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c
+++ b/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c

@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0

+#include "autoconf.h"
 #include <linux/err.h>
 #include <string.h>
 #include <bpf/btf.h>
--

2.25.4