Thread (5 messages) 5 messages, 5 authors, 2020-07-29

Re: [PATCH bpf-next] selftests/bpf: don't destroy failed link

From: YiFei Zhu <hidden>
Date: 2020-07-29 05:31:12
Also in: bpf

On Tue, Jul 28, 2020 at 11:51 PM Andrii Nakryiko [off-list ref] wrote:
Check that link is NULL or proper pointer before invoking bpf_link__destroy().
Not doing this causes crash in test_progs, when cg_storage_multi selftest
fails.

Cc: YiFei Zhu <redacted>
Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORAGE behavior on shared egress + ingress")
Signed-off-by: Andrii Nakryiko <redacted>
---
 .../bpf/prog_tests/cg_storage_multi.c         | 42 ++++++++++++-------
 1 file changed, 28 insertions(+), 14 deletions(-)
Awesome! Thanks for the fix. I did not realize the return was a -errno
rather than NULL like open_and_load.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help