On Mon, 2020-07-27 at 10:10 -0700, David Miller wrote:

From: Julia Lawall <Julia.Lawall@inria.fr>
Date: Sun, 26 Jul 2020 12:58:29 +0200

quoted

list_for_each_entry is able to handle an empty list.
The only effect of avoiding the loop is not initializing the
index variable.
Drop list_empty tests in cases where these variables are not
used.

Note that list_for_each_entry is defined in terms of

list_first_entry,

quoted

which indicates that it should not be used on an empty list.  But

in

quoted

list_for_each_entry, the element obtained by list_first_entry is

not

quoted

really accessed, only the address of its list_head field is

compared

quoted

to the address of the list head, so the list_first_entry is safe.

The semantic patch that makes this change is as follows (with

another

quoted

variant for the no brace case): (http://coccinelle.lip6.fr/)

 ...

quoted

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Saeed, please pick this up.

Thank you.

Applied to net-next-mlx5.

Thanks !