Hi Joe,

On Tue, Jul 28, 2020 at 5:48 AM Joe Perches [off-list ref] wrote:

On Mon, 2020-07-27 at 14:44 -0500, Gustavo A. R. Silva wrote:

quoted

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[]

quoted

diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c

[]

quoted

@@ -159,7 +159,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring,
                      break;
              }
              /* follow through when ring_num >= 3 */
-             /* fall through */
+             fallthrough;

Likely the /* follow through ... */ comment can be deleted too

If the "when ring_num >= 3" comment is needed, how should this get
formatted? Maybe something like:

fallthrough; /* when ring_num >= 3 */

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/