Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses
From: Pkshih <pkshih@realtek.com>
Date: 2020-07-27 06:07:41
Also in:
linux-wireless, lkml
On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote:
Make these statements a little simpler. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 14 +++++------ .../rtlwifi/btcoexist/halbtc8192e2ant.c | 23 ++++++++++--------- .../rtlwifi/btcoexist/halbtc8821a2ant.c | 12 +++++----- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 9 ++++---- drivers/net/wireless/realtek/rtlwifi/pci.c | 2 +- 5 files changed, 30 insertions(+), 30 deletions(-)
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.cb/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c index 8d28c68f083e..f9a2d8a6730c 100644--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c@@ -874,11 +874,10 @@ static void halbtc_display_wifi_status(structbtc_coexist *btcoexist, seq_printf(m, "\n %-35s = %s / %s/ %s/ AP=%d ", "Wifi freq/ bw/ traffic", gl_btc_wifi_freq_string[wifi_freq], - ((wifi_under_b_mode) ? "11b" : - gl_btc_wifi_bw_string[wifi_bw]), - ((!wifi_busy) ? "idle" : ((BTC_WIFI_TRAFFIC_TX == - wifi_traffic_dir) ? "uplink" : - "downlink")), + wifi_under_b_mode ? "11b" : gl_btc_wifi_bw_string[wifi_bw], + (!wifi_busy ? "idle" : + wifi_traffic_dir == BTC_WIFI_TRAFFIC_TX ? "uplink" : + "downlink"),
I think this would be better + !wifi_busy ? "idle" : + (wifi_traffic_dir == BTC_WIFI_TRAFFIC_TX ? "uplink" : + "downlink"),
quoted hunk ↗ jump to hunk
ap_num); /* power status */diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.cb/drivers/net/wireless/realtek/rtlwifi/pci.c index 1d0af72ee780..3189d1c50d52 100644--- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c@@ -557,7 +557,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, intprio) if (rtlpriv->rtlhal.earlymode_enable) skb_pull(skb, EM_HDR_LEN); - rtl_dbg(rtlpriv, (COMP_INTR | COMP_SEND), DBG_TRACE, + rtl_dbg(rtlpriv, COMP_INTR | COMP_SEND, DBG_TRACE, "new ring->idx:%d, free: skb_queue_len:%d, free: seq:%x\n", ring->idx, skb_queue_len(&ring->queue),