Re: [PATCH v2 net-next 01/15] qed: reformat "qed_chain.h" a bit
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2020-07-22 22:33:17
Also in:
bpf, linux-rdma, lkml
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2020-07-22 22:33:17
Also in:
bpf, linux-rdma, lkml
On Thu, Jul 23, 2020 at 01:10:31AM +0300, Alexander Lobakin wrote:
Reformat structs and macros definitions a bit prior to making functional changes. Signed-off-by: Alexander Lobakin <redacted> Signed-off-by: Igor Russkikh <redacted> Signed-off-by: Michal Kalderon <redacted> include/linux/qed/qed_chain.h | 126 ++++++++++++++++++---------------- 1 file changed, 66 insertions(+), 60 deletions(-)diff --git a/include/linux/qed/qed_chain.h b/include/linux/qed/qed_chain.h index 7071dc92b4e2..087073517c09 100644 +++ b/include/linux/qed/qed_chain.h@@ -26,9 +26,9 @@ enum qed_chain_mode { }; enum qed_chain_use_mode { - QED_CHAIN_USE_TO_PRODUCE, /* Chain starts empty */ - QED_CHAIN_USE_TO_CONSUME, /* Chain starts full */ - QED_CHAIN_USE_TO_CONSUME_PRODUCE, /* Chain starts empty */ + QED_CHAIN_USE_TO_PRODUCE, /* Chain starts empty */ + QED_CHAIN_USE_TO_CONSUME, /* Chain starts full */ + QED_CHAIN_USE_TO_CONSUME_PRODUCE, /* Chain starts empty */ }; enum qed_chain_cnt_type {@@ -40,84 +40,86 @@ enum qed_chain_cnt_type { }; struct qed_chain_next { - struct regpair next_phys; - void *next_virt; + struct regpair next_phys; + void *next_virt; };
I'm surprised this is considered an improvement?? I've been encouring people to go the other way, maintaining vertical alignment is harmful to backporting.. Jason