Thread (2 messages) 2 messages, 2 authors, 2020-07-20

Re: [PATCH 3/14 v3] ath9k: Check the return value of pcie_capability_read_*()

From: Kalle Valo <hidden>
Date: 2020-07-20 17:09:55
Also in: linux-pci, linux-wireless, lkml

"Saheed O. Bolarinwa" [off-list ref] wrote:
On failure pcie_capability_read_dword() sets it's last parameter, val
to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
failure. This would introduce a bug because (x & x) == (~0 & x).

This bug can be avoided without changing the function's behaviour if the
return value of pcie_capability_read_dword is checked to confirm success.

Check the return value of pcie_capability_read_dword() to ensure success.

Suggested-by: Bjorn Helgaas <redacted>
Signed-off-by: Bolarinwa Olayemi Saheed <redacted>
Signed-off-by: Kalle Valo <redacted>
Patch applied to ath-next branch of ath.git, thanks.

9a8ab2bfb678 ath9k: Check the return value of pcie_capability_read_*()

-- 
https://patchwork.kernel.org/patch/11660731/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help