Re: [PATCH] net: ethernet: et131x: Remove redundant register read

From
Andrew Lunn <andrew@lunn.ch>
Date
2020-07-18 14:54:42
Also in
lkml
Reply to
Mark Einon, 2020-07-17
On Fri, Jul 17, 2020 at 04:21:51PM +0100, Mark Einon wrote:
On Fri, 2020-07-17 at 15:40 +0200, Andrew Lunn wrote:
quoted
On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote:
quoted
Following the removal of an unused variable assignment (remove
unused variable 'pm_csr') the associated register read can also go,
as the read also occurs in the subsequent 
call.
Hi Mark

Do you have any hardware documentation which indicates these read are
not required? Have you looked back through the git history to see if
there are any comments about these read?

Hardware reads which appear pointless are sometimes very important to
actually make the hardware work.

	 Andrew
Hi Andrew,

Yes - I'm aware of such effects. In the original vendor driver (
https://gitlab.com/einonm/Legacy-et131x) the read of this register ( 
pm_phy_sw_coma) is not wrapped in a function call and is always called
once when needed.

Also in the current kernel driver et1310_in_phy_coma() is called a few
other times without the removed read being made.

The datasheet I have for a similar device (et1011) doesn't say anything
other than the register should be read/write.

So I think this is a safe thing to do. 
Hi Mark

It is good to include this sort of information in the commit
message. It makes it clear you have considered this, and it stops
people like me asking...

	 Andrew
Thread (5 messages) 5 messages, 3 authors, last reply 2020-07-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help