Re: [PATCH net-next] net: ethernet: et131x: Remove unused variable 'pm_csr'

From
David Miller <davem@davemloft.net>
Date
2020-07-18 01:44:02
Also in
lkml
Reply to
Zhang Changzhong, 2020-07-17
From: Zhang Changzhong <redacted>
Date: Fri, 17 Jul 2020 18:33:30 +0800
Gcc report warning as follows:

drivers/net/ethernet/agere/et131x.c:953:6: warning:
 variable 'pm_csr' set but not used [-Wunused-but-set-variable]
  953 |  u32 pm_csr;
      |      ^~~~~~
drivers/net/ethernet/agere/et131x.c:1002:6:warning:
 variable 'pm_csr' set but not used [-Wunused-but-set-variable]
 1002 |  u32 pm_csr;
      |      ^~~~~~
drivers/net/ethernet/agere/et131x.c:3446:8: warning:
 variable 'pm_csr' set but not used [-Wunused-but-set-variable]
 3446 |    u32 pm_csr;
      |        ^~~~~~

After commit 38df6492eb51 ("et131x: Add PCIe gigabit ethernet driver
et131x to drivers/net"), 'pm_csr' is never used in these functions,
so removing it to avoid build warning.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Zhang Changzhong <redacted>
Applied.
Thread (3 messages) 3 messages, 3 authors, last reply 2020-07-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help