RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, July 9, 2020 5:49 AM
To: Ooi, Joyce <redacted>
Cc: Thor Thayer <redacted>; David S . Miller
[off-list ref]; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; Dalon Westergreen
[off-list ref]; Tan, Ley Foon
[off-list ref]; See, Chin Liang [off-list ref];
Nguyen, Dinh [off-list ref]; Westergreen, Dalon
[off-list ref]
Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

On Wed,  8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote:

quoted

+		/* get prefetcher rx poll frequency from device tree */
+		if (of_property_read_u32(pdev->dev.of_node, "rx-poll-

freq",

quoted

+					 &priv->rx_poll_freq)) {
+			dev_info(&pdev->dev, "Defaulting RX Poll Frequency

to 128\n");

quoted

+			priv->rx_poll_freq = 128;
+		}
+
+		/* get prefetcher rx poll frequency from device tree */
+		if (of_property_read_u32(pdev->dev.of_node, "tx-poll-

freq",

quoted

+					 &priv->tx_poll_freq)) {
+			dev_info(&pdev->dev, "Defaulting TX Poll Frequency

to 128\n");

quoted

+			priv->tx_poll_freq = 128;
+		}

I'm no device tree expert but these look like config options rather than HW
description. They also don't appear to be documented in the next patch.

The poll_freq are part of the msgdma prefetcher IP, whereby it specifies the frequency of descriptor polling operation.
I can add the poll_freq description in the next patch.