Re: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp_set()

Andy Duan [off-list ref] writes:

From: Sergey Organov <redacted> Sent: Wednesday, July 8, 2020 4:49 PM

quoted

Andy Duan [off-list ref] writes:

quoted

From: Sergey Organov <redacted> Sent: Tuesday, July 7, 2020
10:43 PM

quoted

Andy Duan [off-list ref] writes:

quoted

From: Sergey Organov <redacted> Sent: Monday, July 6,
2020

10:26 PM

quoted

quoted

Code of the form "if(x) x = 0" replaced with "x = 0".

Code of the form "if(x == a) x = a" removed.

Signed-off-by: Sergey Organov <redacted>
---
 drivers/net/ethernet/freescale/fec_ptp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_ptp.c

b/drivers/net/ethernet/freescale/fec_ptp.c
index e455343..4152cae 100644

--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c

@@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev,

struct

ifreq

quoted

quoted

*ifr)

        switch (config.rx_filter) {
        case HWTSTAMP_FILTER_NONE:
-               if (fep->hwts_rx_en)
-                       fep->hwts_rx_en = 0;
-               config.rx_filter = HWTSTAMP_FILTER_NONE;

 
The original patch seems fine. Thanks!

For the patch: Acked-by: Fugang Duan [off-list ref]

OK, thanks for reviewing!

-- Sergey