Thread (19 messages) 19 messages, 6 authors, 2020-08-20

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

From: Jonas Bonn <hidden>
Date: 2020-07-02 06:14:43
Also in: lkml

Hi Cong,

On 01/07/2020 21:58, Cong Wang wrote:
On Wed, Jul 1, 2020 at 9:05 AM Cong Wang [off-list ref] wrote:
quoted
On Tue, Jun 30, 2020 at 2:08 PM Josh Hunt [off-list ref] wrote:
quoted
Do either of you know if there's been any development on a fix for this
issue? If not we can propose something.
If you have a reproducer, I can look into this.
Does the attached patch fix this bug completely?
It's easier to comment if you inline the patch, but after taking a quick 
look it seems too simplistic.

i)  Are you sure you haven't got the return values on qdisc_run reversed?
ii) There's a "bypass" path that skips the enqueue/dequeue operation if 
the queue is empty; that needs a similar treatment:  after releasing 
seqlock it needs to ensure that another packet hasn't been enqueued 
since it last checked.

/Jonas
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help