Re: [PATCH v2 net-next 08/11] sfc_ef100: statistics gathering
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-07-31 20:27:35
On Fri, 31 Jul 2020 14:00:24 +0100 Edward Cree wrote:
+ core_stats->rx_packets = stats[EF100_STAT_port_rx_packets]; + core_stats->tx_packets = stats[EF100_STAT_port_tx_packets]; + core_stats->rx_bytes = stats[EF100_STAT_port_rx_bytes]; + core_stats->tx_bytes = stats[EF100_STAT_port_tx_bytes];
+ core_stats->multicast = stats[EF100_STAT_port_rx_multicast];
+ core_stats->rx_crc_errors = stats[EF100_STAT_port_rx_bad]; + core_stats->rx_frame_errors = + stats[EF100_STAT_port_rx_align_error]; + core_stats->rx_fifo_errors = stats[EF100_STAT_port_rx_overflow];
Since this is a new driver please stop reporting this in ethtool. They clearly have a perfect match with the standard stats there is no need for duplication.