Thread (4 messages) 4 messages, 2 authors, 2020-07-31

Re: [PATCH ipsec 1/2] espintcp: handle short messages instead of breaking the encap socket

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2020-07-31 07:02:09

On Wed, Jul 29, 2020 at 06:38:42PM +0200, Sabrina Dubroca wrote:
Currently, short messages (less than 4 bytes after the length header)
will break the stream of messages. This is unnecessary, since we can
still parse messages even if they're too short to contain any usable
data. This is also bogus, as keepalive messages (a single 0xff byte),
though not needed with TCP encapsulation, should be allowed.

This patch changes the stream parser so that short messages are
accepted and dropped in the kernel. Messages that contain a valid SPI
or non-ESP header are processed as before.

Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)")
Reported-by: Andrew Cagney <redacted>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help