On 7/30/20 4:38 PM, David Miller wrote:

From: Roopa Prabhu <redacted>
Date: Mon, 27 Jul 2020 12:21:17 -0700

quoted

+/**
+ *   dev_get_proto_down_reason - returns protodown reason
+ *
+ *   @dev: device
+ */
+u32 dev_get_proto_down_reason(const struct net_device *dev)
+{
+     return dev->proto_down_reason;
+}
+EXPORT_SYMBOL(dev_get_proto_down_reason);

This helper is excessive, please remove it and just dereference the
netdev member directly.

Thank you.

agree, will send v2. (it was meant to do more than just that initially)