Re: [PATCH v3 net-next 03/11] qed: swap param init and publish
From: Jiri Pirko <jiri@resnulli.us>
Date: 2020-07-29 12:51:07
Wed, Jul 29, 2020 at 01:38:38PM CEST, irusskikh@marvell.com wrote:
In theory that could lead to race condition
Describe the problem, tell the codebase what to do. Plus, this looks like a -net material. Please consider pushing this separatelly with proper "fixes" tag.
quoted hunk ↗ jump to hunk
Signed-off-by: Igor Russkikh <redacted> Signed-off-by: Alexander Lobakin <redacted> Signed-off-by: Michal Kalderon <redacted> --- drivers/net/ethernet/qlogic/qed/qed_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c index a62c47c61edf..4e3316c6beb6 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c +++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c@@ -75,8 +75,8 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)QED_DEVLINK_PARAM_ID_IWARP_CMT, value); - devlink_params_publish(dl); cdev->iwarp_cmt = false; + devlink_params_publish(dl); return dl; -- 2.17.1