Thread (10 messages) 10 messages, 4 authors, 2020-07-23

Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

From: "Eelco Chaudron" <echaudro@redhat.com>
Date: 2020-07-22 15:31:50


On 22 Jul 2020, at 17:21, Jakub Kicinski wrote:
On Wed, 22 Jul 2020 10:27:52 +0200 Eelco Chaudron wrote:
quoted
This patch makes the masks cache size configurable, or with
a size of 0, disable it.

Reviewed-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Hi Elco!

This patch adds a bunch of new sparse warnings:

net/openvswitch/flow_table.c:376:23: warning: incorrect type in 
assignment (different address spaces)
net/openvswitch/flow_table.c:376:23:    expected struct 
mask_cache_entry *cache
net/openvswitch/flow_table.c:376:23:    got void [noderef] __percpu *
net/openvswitch/flow_table.c:386:25: warning: incorrect type in 
assignment (different address spaces)
net/openvswitch/flow_table.c:386:25:    expected struct 
mask_cache_entry [noderef] __percpu *mask_cache
net/openvswitch/flow_table.c:386:25:    got struct mask_cache_entry 
*cache
net/openvswitch/flow_table.c:411:27: warning: incorrect type in 
assignment (different address spaces)
net/openvswitch/flow_table.c:411:27:    expected struct mask_cache 
[noderef] __rcu *mask_cache
net/openvswitch/flow_table.c:411:27:    got struct mask_cache *
net/openvswitch/flow_table.c:440:35: warning: incorrect type in 
argument 1 (different address spaces)
net/openvswitch/flow_table.c:440:35:    expected struct mask_cache *mc
net/openvswitch/flow_table.c:440:35:    got struct mask_cache 
[noderef] __rcu *mask_cache
Odd, as I’m sure I ran checkpatch :( Will sent an update fixing those!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help