Re: [PATCH bpf-next v3 04/14] xsk: move fill and completion rings to buffer pool

Hi Magnus,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Magnus-Karlsson/xsk-support-shared-umems-between-devices-and-queues/20200720-180143
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cf1105069648446d58adfb7a6cc590013d6886ba)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

net/xdp/xsk_diag.c:88:72: error: no member named 'fq' in 'struct xdp_umem'

           du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
                                                                       ~~~~~~~~  ^
   1 error generated.

vim +88 net/xdp/xsk_diag.c

a36b38aa2af6114 Björn Töpel  2019-01-24  80  
0d80cb4612aa32d Ciara Loftus 2020-07-08  81  static int xsk_diag_put_stats(const struct xdp_sock *xs, struct sk_buff *nlskb)
0d80cb4612aa32d Ciara Loftus 2020-07-08  82  {
0d80cb4612aa32d Ciara Loftus 2020-07-08  83  	struct xdp_diag_stats du = {};
0d80cb4612aa32d Ciara Loftus 2020-07-08  84  
0d80cb4612aa32d Ciara Loftus 2020-07-08  85  	du.n_rx_dropped = xs->rx_dropped;
0d80cb4612aa32d Ciara Loftus 2020-07-08  86  	du.n_rx_invalid = xskq_nb_invalid_descs(xs->rx);
0d80cb4612aa32d Ciara Loftus 2020-07-08  87  	du.n_rx_full = xs->rx_queue_full;
0d80cb4612aa32d Ciara Loftus 2020-07-08 @88  	du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
0d80cb4612aa32d Ciara Loftus 2020-07-08  89  	du.n_tx_invalid = xskq_nb_invalid_descs(xs->tx);
0d80cb4612aa32d Ciara Loftus 2020-07-08  90  	du.n_tx_ring_empty = xskq_nb_queue_empty_descs(xs->tx);
0d80cb4612aa32d Ciara Loftus 2020-07-08  91  	return nla_put(nlskb, XDP_DIAG_STATS, sizeof(du), &du);
0d80cb4612aa32d Ciara Loftus 2020-07-08  92  }
0d80cb4612aa32d Ciara Loftus 2020-07-08  93  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org