Thread (54 messages) 54 messages, 3 authors, 2020-07-20

Re: do a single memdup_user in sctp_setsockopt v2

From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: 2020-07-20 13:08:45
Also in: linux-sctp

On Sun, Jul 19, 2020 at 06:27:27PM -0700, David Miller wrote:
From: Christoph Hellwig <hch@lst.de>
Date: Sun, 19 Jul 2020 09:21:37 +0200
quoted
here is a resend of my series to lift the copy_from_user out of the
individual sctp sockopt handlers into the main sctp_setsockopt
routine.

Changes since v1:
 - fixes a few sizeof calls.
 - use memzero_explicit in sctp_setsockopt_auth_key instead of special
   casing it for a kzfree in the caller
 - remove some minor cleanups from sctp_setsockopt_autoclose to keep
   it closer to the existing version
 - add another little only vaguely related cleanup patch
This is all very mechanical and contained to the sockopt code of SCTP,
so I reviewed this a few times and applied it to net-next.

Thanks Christoph!
Yep! And way easier to work with, function by function.

Just for the records,
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help