Re: [PATCH 1/1] mvpp2: xdp ethtool stats
From: David Miller <davem@davemloft.net>
Date: 2020-07-01 19:48:02
From: Sven Auhagen <redacted> Date: Wed, 1 Jul 2020 17:30:44 +0200
static void mvpp2_read_stats(struct mvpp2_port *port)
{
u64 *pstats;
+ const struct mvpp2_ethtool_counter *s;
+ struct mvpp2_pcpu_stats xdp_stats = {};
int i, q;Reverse christmas tree ordering here, please.
quoted hunk ↗ jump to hunk
@@ -3166,6 +3271,7 @@ struct xdp_frame **frames, u32 flags) { struct mvpp2_port *port = netdev_priv(dev); + struct mvpp2_pcpu_stats *stats = this_cpu_ptr(port->stats); int i, nxmit_byte = 0, nxmit = num_frame; u32 ret; u16 txq_id;
Likewise.
quoted hunk ↗ jump to hunk
@@ -3258,11 +3374,10 @@ enum dma_data_direction dma_dir; struct bpf_prog *xdp_prog; struct xdp_buff xdp; + struct mvpp2_pcpu_stats ps = {}; int rx_received; int rx_done = 0; u32 xdp_ret = 0; - u32 rcvd_pkts = 0; - u32 rcvd_bytes = 0;
Likewise.