Thread (5 messages) 5 messages, 2 authors, 2020-07-01

Re: [PATCH net-next] sfc: remove udp_tnl_has_port

From: Edward Cree <hidden>
Date: 2020-07-01 14:32:16

On 30/06/2020 23:50, Jakub Kicinski wrote:
Nothing seems to have ever been calling this.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
That was intended to be used by encap offloads (TX csum and TSO), which
 we only recently realised we hadn't upstreamed the rest of; the
 udp_tnl_has_port method would be called from our ndo_features_check().
I'll try to get to upstreaming that support after ef100 is in, hopefully
 within this cycle, but if you don't want this dead code lying around in
 the meantime then have an
Acked-by: Edward Cree <redacted>
 and I can revert it when I add the code that calls it.
(And don't worry, ef100 doesn't use ugly port-based offloads; it does
 proper CHECKSUM_PARTIAL and GSO_PARTIAL, so it won't have this stuff.)

-ed
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help