Re: [PATCH bpf-next v2 2/4] libbpf: add support for BPF_CGROUP_INET_SOCK_RELEASE
From: Andrii Nakryiko <hidden>
Date: 2020-06-27 00:59:54
Also in:
bpf
On Fri, Jun 26, 2020 at 4:52 PM Stanislav Fomichev [off-list ref] wrote:
On Fri, Jun 26, 2020 at 3:08 PM Andrii Nakryiko [off-list ref] wrote:quoted
On Fri, Jun 26, 2020 at 10:22 AM Stanislav Fomichev [off-list ref] wrote:quoted
Add auto-detection for the cgroup/sock_release programs. Signed-off-by: Stanislav Fomichev <redacted> ---Left a bunch of comments on v1 of this series, oops.No worries, there is not much changed since then, thanks for the review!quoted
But where is the cover letter? Did I miss it?I didn't feel like it deserves a cover letter. The main patch is small, most of the changes are in libbpf/selftests and I mostly split them to make it easier for you to push to github (is it still a requirement or I shouldn't worry about it anymore?).
It's not a requirement, sync script is pretty smart about all that, so no need to do it specifically for the sync purposes. Still a good idea to have selftests separately, IMO. As for the cover letter, unless it's some trivial independent fixes, cover letter ties everything together and is a good place to track "what changed between versions". So I'd recommend adding it anyways.