Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs attached to CPUMAP

On Tue, 23 Jun 2020 22:49:02 -0700
Andrii Nakryiko [off-list ref] wrote:

On Tue, Jun 23, 2020 at 2:40 PM Lorenzo Bianconi [off-list ref] wrote:

quoted

As for DEVMAP, support SEC("xdp_cpumap*") as a short cut for loading

                                ^^^^^^^^^^^

Maybe update desc to include the "/" ?
  

quoted

the program with type BPF_PROG_TYPE_XDP and expected attach type
BPF_XDP_CPUMAP.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---  

Thanks!

Acked-by: Andrii Nakryiko <redacted>

I like this extra "/".

Acked-by: Jesper Dangaard Brouer <redacted>

If we agree, I hope we can also adjust this for devmap in bpf-tree ?

quoted

 tools/lib/bpf/libbpf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 18461deb1b19..16fa3b84ac38 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c

@@ -6866,6 +6866,8 @@ static const struct bpf_sec_def section_defs[] = {
                .attach_fn = attach_iter),
        BPF_EAPROG_SEC("xdp_devmap",            BPF_PROG_TYPE_XDP,
                                                BPF_XDP_DEVMAP),
+       BPF_EAPROG_SEC("xdp_cpumap/",           BPF_PROG_TYPE_XDP,
+                                               BPF_XDP_CPUMAP),
        BPF_PROG_SEC("xdp",                     BPF_PROG_TYPE_XDP),
        BPF_PROG_SEC("perf_event",              BPF_PROG_TYPE_PERF_EVENT),
        BPF_PROG_SEC("lwt_in",                  BPF_PROG_TYPE_LWT_IN),
--

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer