[PATCH bpf-next v5 00/15] implement bpf iterator for tcp and udp sockets · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 01/15] net: bpf: add bpf_seq_afinfo in tcp_iter_state · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 02/15] net: bpf: implement bpf iterator for tcp · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 07/15] net: bpf: add bpf_seq_afinfo in udp_iter_state · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 03/15] bpf: support 'X' in bpf_seq_printf() helper · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 05/15] bpf: add bpf_skc_to_tcp6_sock() helper · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 04/15] bpf: allow tracing programs to use bpf_jiffies64() helper · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 06/15] bpf: add bpf_skc_to_{tcp,tcp_timewait,tcp_request}_sock() helpers · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 10/15] selftests/bpf: move newer bpf_iter_* type redefining to a new header file · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 13/15] selftests/bpf: implement sample tcp/tcp6 bpf_iter programs · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 11/15] selftests/bpf: refactor some net macros to bpf_tracing_net.h · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 08/15] net: bpf: implement bpf iterator for udp · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 09/15] bpf: add bpf_skc_to_udp6_sock() helper · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 12/15] selftests/bpf: add more common macros to bpf_tracing_net.h · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 14/15] selftests/bpf: implement sample udp/udp6 bpf_iter programs · Yonghong Song <hidden> · 2020-06-23
[PATCH bpf-next v5 15/15] selftests/bpf: add tcp/udp iterator programs to selftests · Yonghong Song <hidden> · 2020-06-23
Re: [PATCH bpf-next v5 00/15] implement bpf iterator for tcp and udp sockets · Alexei Starovoitov <hidden> · 2020-06-25

STALE2221d LANDED: 1 (0M)

Revisions (5)

2020-06-17 v1 [diff vs current]
2020-06-21 v2 [diff vs current]
2020-06-23 v3 [diff vs current]
2020-06-23 v4 [diff vs current]
2020-06-23 v5 current

[PATCH bpf-next v5 03/15] bpf: support 'X' in bpf_seq_printf() helper

From: Yonghong Song <hidden>
Date: 2020-06-23 23:08:18
Also in: bpf
Subsystem: bpf [general] (safe dynamic programs and tools), bpf [security & lsm] (security audit and enforcement using bpf), bpf [tracing], the rest, tracing · Maintainers: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman, Kumar Kartikeya Dwivedi, KP Singh, Matt Bobrowski, Song Liu, Linus Torvalds, Steven Rostedt, Masami Hiramatsu

'X' tells kernel to print hex with upper case letters.
/proc/net/tcp{4,6} seq_file show() used this, and
supports it in bpf_seq_printf() helper too.

Acked-by: Martin KaFai Lau <redacted>
Signed-off-by: Yonghong Song <redacted>
---
 kernel/trace/bpf_trace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index e729c9e587a0..dbee30e2ad91 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c

@@ -681,7 +681,8 @@ BPF_CALL_5(bpf_seq_printf, struct seq_file *, m, char *, fmt, u32, fmt_size,
 		}
 
 		if (fmt[i] != 'i' && fmt[i] != 'd' &&
-		    fmt[i] != 'u' && fmt[i] != 'x') {
+		    fmt[i] != 'u' && fmt[i] != 'x' &&
+		    fmt[i] != 'X') {
 			err = -EINVAL;
 			goto out;
 		}

-- 
2.24.1