Thread (13 messages) 13 messages, 4 authors, 2020-06-06

Re: [bpf-next PATCH 1/3] bpf: refactor sockmap redirect code so its easy to reuse

From: John Fastabend <john.fastabend@gmail.com>
Date: 2020-06-01 15:17:40
Also in: bpf

Jakub Sitnicki wrote:
On Fri, 29 May 2020 16:06:41 -0700
John Fastabend [off-list ref] wrote:
quoted
We will need this block of code called from tls context shortly
lets refactor the redirect logic so its easy to use. This also
cleans up the switch stmt so we have fewer fallthrough cases.

No logic changes are intended.

Fixes: d829e9c4112b5 ("tls: convert to generic sk_msg interface")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
---
Keeping out_free in the extracted helper might have been cleaner.
Perhaps. I had the out_free there at first then went back and did it
the way its done here after writing 2/3.

Thanks for the review!
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help